Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail because of missing urls file #34

Closed
sbraz opened this issue Jan 20, 2016 · 3 comments
Closed

Tests fail because of missing urls file #34

sbraz opened this issue Jan 20, 2016 · 3 comments

Comments

@sbraz
Copy link
Contributor

sbraz commented Jan 20, 2016

...E..
======================================================================
ERROR: test_handler.test_load_examples
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.4/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/tmp/urlwatch-2.0/test/test_handler.py", line 37, in test_load_examples
    txt_jobs = UrlsTxt(os.path.join(os.path.dirname(__file__), 'data', 'urls.txt')).load_secure()
  File "/tmp/urlwatch-2.0/lib/urlwatch/storage.py", line 155, in load_secure
    jobs = self.load()
  File "/tmp/urlwatch-2.0/lib/urlwatch/storage.py", line 202, in load
    return list(self._parse(open(self.filename)))
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/urlwatch-2.0/test/data/urls.txt'

----------------------------------------------------------------------
Ran 6 tests in 0.059s

FAILED (errors=1)
@idella
Copy link

idella commented Jan 22, 2016

The folder data and the file urls.txt are clearly visible in the source repo. They have simply been missed being added into the tarball

@thp thp closed this as completed in eaf6610 Jan 27, 2016
thp added a commit that referenced this issue Jan 27, 2016
@thp
Copy link
Owner

thp commented Jan 27, 2016

Some of these test cases like the urls.txt test case is mostly for regression testing during development, so it's okay if the files are missing when urlwatch is installed. However, I've now also added test/data to the source tarball, so people grabbing the tarball can also run the regression tests.

@sbraz
Copy link
Contributor Author

sbraz commented Jan 27, 2016

That's awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants