Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Provide hooks with content_type (raw from server) and mime_type #459
thp left a comment
I like the basic premise of this PR, but have been thinking a bit more about it.
Your proposed use case:
This is a very narrow use case, it might be better to extend it to not just a content type, but to return a dictionary of headers for every request? The filter itself might be a bit more complicated then, but it is only written once. You could then also filter for other header values (I can't think of a good example, but maybe format/filter certain CMS with the
Then again, maybe it's good enough if we provide an Atom feed filter and users just manually opt in to use that filter for jobs?
In any case, right now it doesn't handle the
To summarize, it's still a nice idea, but not sure if the added complexity and potential backwards compatibility issues (user-written job types where the
Thanks for the review.