Fix diff generation for lines without newline #550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than keeping the line endings before passing to diff, then joining the resulting lines with '', strip the line endings and join
with '\n'. This ensures a that each output line has exactly one trailing newline.
Possible issues:
os.linesep
might be better for Windows, but only if it is going to a text file, and I think most Windows stuff handles lines terminated with just LF fine now.