(BUG FIX) Fix order submission crash due to missing "exchange" parameter #468
Conversation
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 45.50% 45.49% -0.02%
==========================================
Files 210 210
Lines 48818 48826 +8
==========================================
- Hits 22217 22213 -4
- Misses 24343 24351 +8
- Partials 2258 2262 +4
Continue to review full report at Codecov.
|
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
| @@ -898,6 +904,8 @@ func (s *RPCServer) CancelOrder(ctx context.Context, r *gctrpc.CancelOrderReques | |||
| ID: r.OrderId, | |||
| Side: order.Side(r.Side), | |||
| WalletAddress: r.WalletAddress, | |||
| Pair : currency.NewPairFromStrings(r.Pair.Base,r.Pair.Quote), | |||
|
|
|||
| }) | |||
|
|
|||
| return &gctrpc.CancelOrderResponse{}, err | |||
There was a problem hiding this comment.
if you feel comfortable with protobuf/gRPC you could also update the CancelOrderResponse{} message here to pass back a confirmation but its kind of out of scope of the original fix and I am happy to open up a PR for it at a later time
There was a problem hiding this comment.
Yes you can , let's fix them as quickly as possible
There was a problem hiding this comment.
We can do this in a separate PR
xtda
changed the title
engine/rpcserver.go
Outdated
| @@ -898,6 +904,8 @@ func (s *RPCServer) CancelOrder(ctx context.Context, r *gctrpc.CancelOrderReques | |||
| ID: r.OrderId, | |||
| Side: order.Side(r.Side), | |||
| WalletAddress: r.WalletAddress, | |||
| Pair : currency.NewPairFromStrings(r.Pair.Base,r.Pair.Quote), | |||
There was a problem hiding this comment.
Go formatting issues picked up by our linter:
Please run gofmt -w rpcserver.go & push up the fix.
| @@ -898,6 +904,7 @@ func (s *RPCServer) CancelOrder(ctx context.Context, r *gctrpc.CancelOrderReques | |||
| ID: r.OrderId, | |||
| Side: order.Side(r.Side), | |||
| WalletAddress: r.WalletAddress, | |||
| Pair: currency.NewPairFromStrings(r.Pair.Base, r.Pair.Quote), | |||
There was a problem hiding this comment.
Have adopted the suggestion of gofmt
|
|
||
| if err != nil { | ||
| return &gctrpc.SubmitOrderResponse{}, err | ||
| } | ||
|
|
There was a problem hiding this comment.
Here, I also suggest merging it into the master branch. It would panic if &gctrpc.SubmitOrderResponse is nil
…ter (thrasher-corp#468) * fix the return problem * fix the return problem * add the mandatory parameter * fix the symbol empity problem * fix the symbol empty problem * add Pair parameter for order.Cancel parameters * follow the gofmt rule Co-authored-by: MK <mk@MKdeMacBook-Pro.local>
PR Description
RPC server crashed when requesting submit by using gctcli
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist