-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: PSQL Migration syntax fix #550
Conversation
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
- Coverage 45.68% 44.93% -0.75%
==========================================
Files 234 246 +12
Lines 56464 59411 +2947
==========================================
+ Hits 25797 26699 +902
- Misses 27875 29666 +1791
- Partials 2792 3046 +254
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
On master:
ERROR postgres.sql: failed to run SQL migration: failed to execute SQL query "ALTER TABLE candle ALTER COLUMN aseet SET NULL;\n": pq: syntax error at or near "NULL"
PR:
Connected to: localhost 2020/09/09 14:01:20 OK 20200814113829_update_withdrawal_history_add_not_null_to_exchange_name_id\postgres.sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 4 rules errored during the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 4 rules errored during the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Approved. Nice work!
Goosed it all the way down and all the way up, no issues.... no tissues needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACKKKK
PR Description
There was an issue migrating down using psql:
Fixes a typo on migrations and also updates to use PSQL syntax
Type of change
How has this been tested
.\dbmigrate.exe -command=up
.\dbmigrate.exe -command=down
Until it worked