section inheritance #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhman
force-pushed
the
section-inheritance
branch
2 times, most recently
from
76e52ef
to
a8e54ed
Compare
Merged
This adds a new InheritanceConfigParser, which supports section inheritance. This also includes nested and multiple-inheritance.
This: - makes SafeConfigParser inherit from InheritanceConfigParser removes - removes redundant logic to add the default config section to the environment - removes duplicate definitions of the default section name This also deduplicates logic spread between RawConfigParser.items() and the RawConfigParser.get() call stack.
This replaces six.moves.configparser with configparser. A direct reference to str was also replaced with a method call to that object.
buhman
force-pushed
the
section-inheritance
branch
from
a8e54ed
to
a09d05a
Compare
This allows tests to be imported by other tests.
This adds several tests for InheritanceConfigParser.
buhman
force-pushed
the
section-inheritance
branch
from
92e8556
to
2f1f952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #6
I think the best way to re-summarize why this is awesome by showing you this actually valid config.
This may or may not break compatibility with python<=3.2; we might need to make hubble depend on the backporteddone.configparserfrom 3.3 for this to work on obsolete python versions, or maybe add some even uglier hacks.We should also consider breaking most of
configout into a separate library, with proper unit testing. I'd also like to gut parts ofshellinto this newconfiglibrary as well.merge #7 first for a sane diff