Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination on top of the page #501

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Add pagination on top of the page #501

merged 1 commit into from
Jan 30, 2017

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Dec 4, 2016

We show quite a few posts per page, and it's not always clear which page you're on.

This adds the pagination bar to the topics#show and private_topics#show pages by default. View hooks are provided so it's easy to disable it.


thredded-pagination-top

We show quite a few posts per page, and it's not always clear which page
you're on.

This adds the pagination bar to the topics#show and private_topics#show
pages by default. View hooks are provided so it's easy to disable these.
@glebm
Copy link
Collaborator Author

glebm commented Jan 24, 2017

@timdiggins @jayroh Is this OK to merge?

@glebm glebm added this to the v0.9.4 milestone Jan 30, 2017
@glebm
Copy link
Collaborator Author

glebm commented Jan 30, 2017

@jayroh @timdiggins I'm going to merge this so that we can focus on v0.10.0 without merge conflicts. 🚢 I'll address your feedback if any in a follow-up PR.

@glebm glebm merged commit 5ad1377 into master Jan 30, 2017
@glebm glebm deleted the pagination-top branch January 30, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants