Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLShadowMap: Update ctor signature. #42

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

Mugen87
Copy link
Contributor

@Mugen87 Mugen87 commented Mar 12, 2021

Why

Updates required for mrdoob/three.js#21452.

What

The third ctor parameter of WebGLShadowMap is now of type WebGLCapabilities.

Checklist

  • Added myself to contributors table
  • Ready to be merged

The third parameter is now of type `WebGLCapabilities`.
@Mugen87 Mugen87 changed the title Update ctor signature. WebGLShadowMap : Update ctor signature. Mar 12, 2021
@Mugen87 Mugen87 changed the title WebGLShadowMap : Update ctor signature. WebGLShadowMap: Update ctor signature. Mar 12, 2021
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🌟

@joshuaellis joshuaellis merged commit 50d37e1 into three-types:dev Mar 13, 2021
@joshuaellis joshuaellis mentioned this pull request Mar 13, 2021
Closed
18 tasks
@joshuaellis joshuaellis added this to the r127 milestone Mar 13, 2021
@Mugen87 Mugen87 deleted the patch-3 branch March 13, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants