Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Plane.d.ts #47

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Update Plane.d.ts #47

merged 2 commits into from
Mar 18, 2021

Conversation

Mugen87
Copy link
Contributor

@Mugen87 Mugen87 commented Mar 16, 2021

Why

Plane.intersectLine() returns now null instead of undefined, see mrdoob/three.js#21468.

What

Replaced undefined with null.

Checklist

  • Added myself to contributors table
  • Ready to be merged

@Mugen87
Update Plane.d.ts
c4c0ef5 
`intersectLine()` returns now `null` instead of `undefined`.
joshuaellis
joshuaellis approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution ⭐

@joshuaellis joshuaellis merged commit cb5d9cf into three-types:dev Mar 18, 2021
@joshuaellis joshuaellis mentioned this pull request Mar 20, 2021
Closed
18 tasks
@Mugen87 Mugen87 deleted the patch-1 branch March 21, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mugen87 @joshuaellis