Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebGLRenderer.d.ts #59

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Update WebGLRenderer.d.ts #59

merged 1 commit into from
Mar 26, 2021

Conversation

Mugen87
Copy link
Contributor

@Mugen87 Mugen87 commented Mar 25, 2021

Why

maxMorphTargets and maxMorphNormals have been removed from the public interface of WebGLRenderer, see mrdoob/three.js#21522.

What

Removes maxMorphTargets and maxMorphNormals from WebGLRenderer.d.ts.

Checklist

  • Added myself to contributors table
  • Ready to be merged

Remove unused properties.
@joshuaellis
Copy link
Member

When doing the .d.ts files originally, was there a reason you excluded private methods instead of appending them with private? Just for my own reference.

@Mugen87
Copy link
Contributor Author

Mugen87 commented Mar 25, 2021

I did not added this code originally so I'm afraid I can answer your question^^.

But during the time the d.ts files resided in the three.js repo, private methods or properties were never added to the type declaration files.

@joshuaellis joshuaellis merged commit 3f5c6b7 into three-types:dev Mar 26, 2021
@Mugen87 Mugen87 deleted the patch-1 branch March 26, 2021 10:02
@joshuaellis joshuaellis mentioned this pull request Mar 28, 2021
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants