Check block hash before writing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure to sync before using the file to avoid corruption on crash
ghost
assigned 
|
What's the performance impact ? |
Codecov Report
@@ Coverage Diff @@
## development #19 +/- ##
===============================================
- Coverage 34.48% 34.24% -0.24%
===============================================
Files 10 10
Lines 464 476 +12
===============================================
+ Hits 160 163 +3
- Misses 279 284 +5
- Partials 25 29 +4
Continue to review full report at Codecov.
|
It's really hard to tell. The performance is impacted by lots of other factors like internet connection speed. I can't do any repetitive measurements. |
|
I will benchmark blak2b separately without the rest |
|
I think the overhead is pretty low
|
zaibon
reviewed
Jan 14, 2019
| return nil, err | ||
| } | ||
|
|
||
| hasher, err := blake2b.New(16, nil) |
There was a problem hiding this comment.
Do you need a new hasher everytime ? can't we have a single hasher and just reset it? Would avoid allocation
maxux
approved these changes
Jan 14, 2019
muhamadazmy
pushed a commit
that referenced
this pull request
Jan 16, 2019
muhamadazmy
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Check block hash before writing (#19) * Block hash checking Also make sure to sync before using the file to avoid corruption on crash * Fix tests * Benchmarking blak2b/128 * Allow 0-fs to start as a daemon (#21) * Allow 0-fs to start as a daemon - also make stderr the default log output stream - add flag to enable daemon mode and pid of the daemon * vendore new dependencies * fix a regression bug This line was removed on a previous PR. * Make sure that the rw layer has same perm as ro This is to make sure that the final merge mount point has same permissions as the flist * Support ReadOnly flag during mounting (#24) * WIP: support ro flag Add code to support mounting a ro directly in that case, we don't do overlay * Make sure if wait fails we cleanly unmount * Original mode works fine * Add ro flag to cmd line interface * use go1.13 for tests * fix connection management in redis pool (#27) * fix connection management in redis pool The pool configuration requires to have the MaxIdle connection to a number bigger then 1 to allow to reuse connection. Without it a new connection is always created. This commit allow to have a total of 10 connection in the pool and keep 2 of them open. * Increase redis pool settings for small improvements Co-authored-by: Maxime Daniel <root@maxux.net> * Go mod (#30) * WIP: support uid/gid values in acl * use simple int32 with default -1 instead * use int64 * Support uid/gid numbers * WIP: fix uid/gid * Finally found the issue with uid/gid * remove log line * remove replace directive in go.mod * move from travis-ci to GithubAction * add more static checks during CI * address linting and statickcheck warnings * update badge on readme * Parent process should only exit successfully after mount is started (#36) * Parent process should only exit successfully is mount is okay * fix sleep * Dev/go/upgrade version (#37) * Upgrade go version in workflows - Also run `go mod tidy` * make vet happy * fix make file Co-authored-by: Christophe de Carvalho <zaibon@users.noreply.github.com> Co-authored-by: Maxime Daniel <root@maxux.net> Co-authored-by: Christophe de Carvalho <christophe.dcpm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure to sync before using the file to avoid
corruption on crash