Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new tools to compute how much cloud units is used by a workload #1492

Merged
merged 4 commits into from
Nov 11, 2020

Conversation

zaibon
Copy link
Contributor

@zaibon zaibon commented Oct 22, 2020

Description

Add a new consumption section in j.tools.zos which allow to compute how much cloud units are consumed by a workload object

Changes

  • Add new module in j.tools.zos
  • Add resource_units methods on all the workloads model

Related Issues

fixes #1423

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@codecov-io
Copy link

codecov-io commented Nov 10, 2020

Codecov Report

Merging #1492 (b2752aa) into development (2b67ab3) will increase coverage by 0.20%.
The diff coverage is 78.12%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1492      +/-   ##
===============================================
+ Coverage        32.15%   32.35%   +0.20%     
===============================================
  Files              134      134              
  Lines            12754    12822      +68     
===============================================
+ Hits              4101     4149      +48     
- Misses            8653     8673      +20     
Impacted Files Coverage Δ
jumpscale/clients/explorer/models.py 96.42% <78.12%> (-3.06%) ⬇️
...scale/packages/threebot_deployer/chats/threebot.py 21.66% <0.00%> (-0.12%) ⬇️
jumpscale/sals/marketplace/deployer.py 12.53% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b67ab3...b2752aa. Read the comment docs.

Copy link

@LeeSmet LeeSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the idea of giving 50GB of SSD for containers for free, but it is what it is I guess

jumpscale/clients/explorer/models.py Outdated Show resolved Hide resolved
jumpscale/clients/explorer/models.py Outdated Show resolved Hide resolved
Copy link

@LeeSmet LeeSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xmonader xmonader merged commit 2bd893d into development Nov 11, 2020
@xmonader xmonader deleted the development_workload_usage branch November 11, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of a tool to compute how much cloud unit a workload consumes
4 participants