Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python SDK #88

Closed
wants to merge 311 commits into from
Closed

Fix Python SDK #88

wants to merge 311 commits into from

Conversation

scottyeager
Copy link

@scottyeager scottyeager commented Oct 30, 2023

Fixes #87. A couple Python examples are included. This change will break the existing examples in yaml/go though, so those still need to be updated.

Rodina222 and others added 30 commits September 7, 2023 17:03
…source

implement the deployment resource
…resources

Development add name gateway resources
…resource

Development add fqdnGateway resource
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…ions/checkout-4

Bump actions/checkout from 2 to 4
@scottyeager scottyeager changed the title Fix sdks and add python example Fix Python SDK Aug 12, 2024
@@ -42,6 +43,9 @@ func Provider() p.Provider {
infer.Resource[*GatewayFQDN](),
},
Config: infer.Config[*Config](),
ModuleMap: map[tokens.ModuleName]tokens.ModuleName{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check #87.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the index change in another pr, because it needs an update in all sdks, examples and tests too

Copy link
Collaborator

@rawdaGastan rawdaGastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add examples in another pr?

@scottyeager scottyeager deleted the development_fix_sdks branch August 14, 2024 15:21
@threefoldtech threefoldtech deleted a comment from rawdaGastan Aug 14, 2024
@scottyeager
Copy link
Author

Changes made on other PRs. Thanks @rawdaGastan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python sdk has clashing package and module
8 participants