Implement manage gateways in playground #1215
Conversation
MohamedElmdary
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
Mahmoud-Emad,
amiraabouhadid and
Omarabdul3ziz
as code owners
…oup_deployment_files_ui
|
after deploying a micro vm, couldn't list it
|
|
the network name and the IP shouldn't be editable
|
|
add an option for the user while deploying the gateway to allow pass-through or not. (add tool-tip to explain what it's used for) |
| await this.tfClient.applyAllExtrinsics(ext1); | ||
| await this.tfClient.applyAllExtrinsics(ext2); |
There was a problem hiding this comment.
let's apply these extrinsics together but the new ones first on the list then the old ones
There was a problem hiding this comment.
@AhmedHanafy725 What text should I add on the tooltip for explaining pass-through?
There was a problem hiding this comment.
let's apply these extrinsics together but the new ones first on the list then the old ones
Merged both together
There was a problem hiding this comment.
Added tls pass through option
…oup_deployment_files_ui
It's already readonly user can only copy them! |
Found the issue and fixed and tested on all solutions |
|
Great job, one small comment, what do you think if we replaced the check box of the custom domain option to be the same as the custom domain as added in the other solutions, |
|
the gateway keys are not migrated while listing the instances |
|
when deploying a peertube instance, the name contract contains
|
|
I was trying to test the changes but the playground failed while building the project.
|
…oup_deployment_files_ui
Should be fixed was an issue related to types but didn't show in development mode for some reason |
|
While testing i found that all deployments that i had already deployed from playground.dev.grid.tf were loaded successfully when i ran the playground from this branch except for kubernetes, when i tried to list the k8s deployment it failed to do so, however the key was sucessfully updated as seen in the polkadot ui.
and when i tried to deploy a k8s deployment directly from this branch it failed to load and it also got stuck at the
|
We didn't apply any updates to k8s but by default k8s applying migration for it's contracts so that why it cases the issue |
Indeed, when i checked the instances that were deployed before they were listed without any issues and then i deployed a new instance and again it got listed without any issues.
|
* Update listing path and add migration * Fix migrating * Fix migrating path * Check storageType before apply exts and rename deploymentPath method * Implement manage gateways in playground (#1215) * Add dialog to deploy gateway * Fix gateways listing & deploying path * Add listing gateways * Add list & deleting gateways * Add dialog to micro vm * Update project name in all solutions * Update old contracts projectName * Fix projectName path (add missing '/') * Add missing 'no-data-text' * Fix listing issue * Merge ext1/ext2 to be applied together * Remove contractId check * Fix typo backends to backend * Add tls pass through option * Update tooltip * Remove unload (loaded with no contracts) deployments from listing * Use domainName component instead of new template * Add visit action in gateways table * Migrate gateways from old solutions * add prefix projectName + twinId + gatewayName to gateways deployed for fullvm & microvm * Remove prefix while listing * Fix building errors * Fix issue in deploying and listing k8s
Issues