Assign ipv6 and gw6 to vm via config #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on slaac to give ipv6 to VMs now it's done explicitly via cidata (cloud init data) provided to the vm This means cloud-container now also disable router advertisment on interfaces. This also mean ipv6 is not provided unless requested in the workload. This was a problem before because it was conflicting with other configurable routes for ipv6
muhamadazmy
requested review from
delandtj,
MarioBassem,
ashraffouda,
rawdaGastan and
xmonader
as code owners
AbdelrahmanElawady
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of relying on slaac to give ipv6 to VMs now it's done explicitly via cidata (cloud init data) provided to the vm
This means cloud-container now also disable router advertisment on interfaces.
This also mean ipv6 is not provided unless requested in the workload. This was a problem before because it was conflicting with other configurable routes for ipv6
Changes