Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing a newer JVM leaves parts of the old JVM #112

Open
Adrodoc opened this issue Aug 9, 2018 · 3 comments
Open

Installing a newer JVM leaves parts of the old JVM #112

Adrodoc opened this issue Aug 9, 2018 · 3 comments

Comments

@Adrodoc
Copy link

Adrodoc commented Aug 9, 2018

If you ugrade or downgrade your JVM it simply unzips the jvm.jar in the working directory. This leaves files of the old JVM that are not contained in the new JVM.
One problem with this is that there is no guarantee that this JVM hybrid works properly as it may contain optional configuration files of a different java version.
On top of that this causes unneccessary space consumption.

PS:
I am using getdown 1.7.0
@Adrodoc
Copy link
Author

Adrodoc commented Aug 9, 2018

Same with getdown 1.7.1

@Adrodoc
Copy link
Author

Adrodoc commented Aug 17, 2018

As an example: updating from java 7u40 to java 10.0.2 you get the error:

<JAVA_HOME>/lib/ext exists, extensions mechanism no longer supported; Use -classpath instead.
.Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

pb00068 added a commit to pb00068/getdown that referenced this issue Nov 29, 2018
@pb00068
Fix for threerings#112
dd9c83a 
Cleans content of each found directory when unpacking a new java_vm.
Fixes the problem when java_wm was build using standard jar. 
For pack200 this remains unresolved.
samskivert added a commit that referenced this issue Nov 30, 2018
@samskivert
Merge pull request #170 from pb00068/unPackFix
37b6575 
Fix for #112, installing a newer JVM leaves parts of the old JVM
@asabanas
Copy link

The previously applied pull request does not fix the problem with existing directories of the old JVM not being cleaned up if they do not exist in the new JVM. Please consider the following pull request that solves this problem: #257

samskivert added a commit that referenced this issue Oct 19, 2021
@samskivert
Merge pull request #257 from asabanas/existing-jvm-cleanup
1cd3a5c 
Fix for #112 - updated existing directories cleanup functionality to remove directories that no longer exist
@Adrodoc Adrodoc mentioned this issue Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asabanas @Adrodoc