Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #112, installing a newer JVM leaves parts of the old JVM #170

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

pb00068
Copy link
Contributor

@pb00068 pb00068 commented Nov 29, 2018

Cleans content of each found directory when unpacking a new java_vm.

Disclaimer.: fixes the problem when java_[os].jar was build using standard jar and not when it was made using pack200. P.S.: pack200 is deprecated https://openjdk.java.net/jeps/336 so probably we need no patch for this special use-case.

Cleans content of each found directory when unpacking a new java_vm.
Fixes the problem when java_wm was build using standard jar. 
For pack200 this remains unresolved.
@samskivert samskivert merged commit 37b6575 into threerings:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants