Skip to content

Commit

Permalink
Merge pull request #147 from threshold-network/use-yarn-18.5.0-in-sli…
Browse files Browse the repository at this point in the history
…ther

Set Node.js version to 18.15.0

We want to fix problem with the yarn build (hardhat compile) command sometimes not generating expected artifacts. The problem is caused by the process silently quitting, which is related to the used version of Node (as descibed in NomicFoundation/hardhat#3877). We've confirmed the problem is reproducible on v18.16.0, now we're downgrading to v18.15.0 to fix the issue.
  • Loading branch information
pdyraga committed Jun 27, 2023
2 parents 3ed292e + 9dd0d2f commit 9837c6d
Showing 1 changed file with 28 additions and 7 deletions.
35 changes: 28 additions & 7 deletions .github/workflows/contracts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18.x"
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "18.15.0"
cache: "yarn"

- name: Install dependencies
Expand All @@ -83,7 +86,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18.x"
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "18.15.0"
cache: "yarn"

- name: Install dependencies
Expand All @@ -104,7 +110,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18.x"
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "18.15.0"
cache: "yarn"

- name: Install dependencies
Expand All @@ -124,7 +133,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18.x"
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "18.15.0"
cache: "yarn"
registry-url: "https://registry.npmjs.org"

Expand Down Expand Up @@ -193,7 +205,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18.x"
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "18.15.0"
cache: "yarn"

- name: Install needed dependencies
Expand Down Expand Up @@ -229,7 +244,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18.x"
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "18.15.0"
cache: "yarn"
registry-url: "https://registry.npmjs.org"

Expand Down Expand Up @@ -284,7 +302,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18"
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "18.15.0"
cache: "yarn"

- uses: actions/setup-python@v4
Expand Down

0 comments on commit 9837c6d

Please sign in to comment.