Run more tests using the streaming implementation #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the places where a `FromWire()` is invoked, call the corresponding streaming `Decode(...)` to check the populated Thrift object.
Codecov Report
@@ Coverage Diff @@
## dev #549 +/- ##
==========================================
+ Coverage 67.32% 67.94% +0.62%
==========================================
Files 135 135
Lines 23531 23531
==========================================
+ Hits 15842 15989 +147
+ Misses 4593 4509 -84
+ Partials 3096 3033 -63
Continue to review full report at Codecov.
|
abhinav
approved these changes
Sep 10, 2021
If there's an error decoding a field of a struct, we'll return early.
For example,
if err := mystruct.Field.Decode(sr); err != nil { return err }
sr.ReadFieldEnd()
sr.ReadStructEnd()
witriew
force-pushed
the
witriew/more_tests_1
branch
from
94e5fca
to
098e30c
Compare
abhinav
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the places where a
FromWire(...)is invoked, call the corresponding streamingDecode(...)to check the populated Thrift object.