Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

taus88 warns on MSVC 2010 #142

Closed
jaredhoberock opened this issue Jun 5, 2012 · 1 comment · Fixed by #150
Closed

taus88 warns on MSVC 2010 #142

jaredhoberock opened this issue Jun 5, 2012 · 1 comment · Fixed by #150

Comments

@jaredhoberock
Copy link
Contributor

Details here: https://groups.google.com/d/msg/thrust-users/TnyjFE2A48I/uptTOAubFN4J
@jaredhoberock
Copy link
Contributor Author

It looks like the muls being performed in xor_engine_combine_max are all just left shifts. We should use something derived from lshift_w instead of mpl::mul to avoid the warnings of overflow.

@jaredhoberock jaredhoberock mentioned this issue Jun 8, 2012
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid warnings of overflow in the computation of xor_combine_engine::max jaredhoberock/thrust
1 participant
@jaredhoberock