Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intrinsic Curiosity Module #503

Merged
merged 17 commits into from
Jan 14, 2022
Merged

Add Intrinsic Curiosity Module #503

merged 17 commits into from
Jan 14, 2022

Conversation

nuance1979
Copy link
Collaborator

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

Implementation of Intrinsic Curiosity Module (ICM, #502)

Paper: https://arxiv.org/pdf/1705.05363.pdf
Reference repos:

ICM is implemented as a decorator because it can be used with any underlying policy. I have prepared an example with atari dqn for simplicity but it might not be able to give better performance for many Atari envs. I'm trying to get an example with VizDoom env running.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #503 (3deb076) into master (a2d76d1) will increase coverage by 0.07%.
The diff coverage is 98.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   94.11%   94.18%   +0.07%     
==========================================
  Files          61       62       +1     
  Lines        4059     4127      +68     
==========================================
+ Hits         3820     3887      +67     
- Misses        239      240       +1     
Flag Coverage Δ
unittests 94.18% <98.55%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelbased/icm.py 97.95% <97.95%> (ø)
tianshou/policy/__init__.py 100.00% <100.00%> (ø)
tianshou/utils/net/discrete.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d76d1...3deb076. Read the comment docs.

tianshou/policy/modelbased/icm.py Outdated Show resolved Hide resolved
tianshou/policy/modelbased/icm.py Outdated Show resolved Hide resolved
tianshou/policy/modelbased/icm.py Outdated Show resolved Hide resolved
examples/vizdoom/vizdoom_a2c_icm.py Outdated Show resolved Hide resolved
tianshou/policy/modelbased/icm.py Outdated Show resolved Hide resolved
@Trinkle23897 Trinkle23897 merged commit a59d96d into thu-ml:master Jan 14, 2022
@Trinkle23897 Trinkle23897 linked an issue Jan 15, 2022 that may be closed by this pull request
8 tasks
@nuance1979 nuance1979 deleted the icm branch January 23, 2022 18:04
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intrinsic Curiosity Module (ICM)
3 participants