Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gym version to >=0.21, fix related CI and update examples/atari #534

Merged
merged 21 commits into from
Feb 24, 2022
Merged

Conversation

gogoduan
Copy link
Contributor

@gogoduan gogoduan commented Feb 23, 2022

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

@Trinkle23897 Trinkle23897 changed the title Fixing test/continuous in supporting of gym version>=0.21 upgrade gym version to >=0.21, fix related CI Feb 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #534 (25980d6) into master (c7e2e56) will decrease coverage by 0.40%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   94.43%   94.03%   -0.41%     
==========================================
  Files          63       63              
  Lines        4298     4306       +8     
==========================================
- Hits         4059     4049      -10     
- Misses        239      257      +18     
Flag Coverage Δ
unittests 94.03% <54.54%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/data/collector.py 94.16% <50.00%> (-1.42%) ⬇️
tianshou/__init__.py 100.00% <100.00%> (ø)
tianshou/policy/multiagent/mapolicy.py 85.71% <0.00%> (-11.91%) ⬇️
tianshou/policy/modelfree/trpo.py 88.52% <0.00%> (-4.92%) ⬇️
tianshou/env/pettingzoo_env.py 91.30% <0.00%> (-4.35%) ⬇️
tianshou/policy/modelfree/npg.py 98.85% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e2e56...25980d6. Read the comment docs.

@Trinkle23897 Trinkle23897 changed the title upgrade gym version to >=0.21, fix related CI upgrade gym version to >=0.21, fix related CI and update examples/atari Feb 24, 2022
@Trinkle23897 Trinkle23897 mentioned this pull request Feb 24, 2022
8 tasks
@Trinkle23897 Trinkle23897 merged commit 23fbc3b into thu-ml:master Feb 24, 2022
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
…ri (thu-ml#534)

Co-authored-by: Jiayi Weng <trinkle23897@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants