Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imitation baselines for offline RL #566

Merged
merged 5 commits into from
Mar 12, 2022

Conversation

nuance1979
Copy link
Collaborator

@nuance1979 nuance1979 commented Mar 10, 2022

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

add imitation baselines for offline RL; make the choice of env/task and D4RL dataset explicit; on expert datasets, IL easily outperforms; after reading the D4RL paper, I'll rerun the exps on medium data

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #566 (8c365c6) into master (74f430e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files          64       64           
  Lines        4376     4376           
=======================================
  Hits         4104     4104           
  Misses        272      272           
Flag Coverage Δ
unittests 93.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/env/worker/ray.py 85.36% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897
Copy link
Collaborator

Is it ready and could you please check the d4rl scripts can successfully run?

@nuance1979
Copy link
Collaborator Author

Is it ready and could you please check the d4rl scripts can successfully run?

Yes, it's ready. I have run the scripts successfully and put the results in README.md .

@Trinkle23897 Trinkle23897 merged commit 9cb74e6 into thu-ml:master Mar 12, 2022
@nuance1979 nuance1979 deleted the offline_baselines branch April 24, 2022 21:00
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
add imitation baselines for offline RL; make the choice of env/task and D4RL dataset explicit; on expert datasets, IL easily outperforms; after reading the D4RL paper, I'll rerun the exps on medium data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants