Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action scaling bug in sac #591

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fix action scaling bug in sac #591

merged 3 commits into from
Apr 11, 2022

Conversation

ChenDRAG
Copy link
Collaborator

@ChenDRAG ChenDRAG commented Apr 11, 2022

close #588

@Trinkle23897 Trinkle23897 linked an issue Apr 11, 2022 that may be closed by this pull request
8 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #591 (aee24fb) into master (f13e415) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   93.52%   93.51%   -0.01%     
==========================================
  Files          66       66              
  Lines        4432     4428       -4     
==========================================
- Hits         4145     4141       -4     
  Misses        287      287              
Flag Coverage Δ
unittests 93.51% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/sac.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 merged commit 75d7c9f into master Apr 11, 2022
@Trinkle23897 Trinkle23897 deleted the ChenDRAG-patch-1 branch April 11, 2022 16:26
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_prob in SAC
3 participants