Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter notebook tutorials using Google Colaboratory #599

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

ChenDRAG
Copy link
Collaborator

@ChenDRAG ChenDRAG commented Apr 17, 2022

Jupyter notebook tutorials could help users get started with Tianshou. In this series of tutorials, I tried my best to explain the most basic usages of serveral core components in Tianshou. Compared to other tutorials hosted in documentation, this one care less about the implementing principles and more about getting started.

One thing I'm not sure about is where I should keep all those jupyter notebook files. For now they are in my Google Drive. I thought about hosting them in Tianshou's repo, but I don't want Tianshou get piled up with tutorials.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #599 (328858f) into master (92456cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          67       67           
  Lines        4433     4433           
=======================================
  Hits         4147     4147           
  Misses        286      286           
Flag Coverage Δ
unittests 93.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ChenDRAG
Copy link
Collaborator Author

Last tutorial added, typo fixed. Done, I think. Hopefully this will easier the learning process of Tianshou.

@Trinkle23897 Trinkle23897 merged commit 57ecebd into thu-ml:master Apr 19, 2022
@simon-bachhuber
Copy link

simon-bachhuber commented Apr 22, 2022

In the notebook L4, there is the following line a couple of times
obs_next = obs
shouldn't it be the other way around? Otherwise the loop always starts from the initial state, it just seems a bit weird.

@ChenDRAG
Copy link
Collaborator Author

@SimiPixel My fault, I will correct it right away

@Trinkle23897 Trinkle23897 linked an issue Apr 23, 2022 that may be closed by this pull request
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A colab(free) way to test examples
4 participants