Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning about async simulation #705

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Conversation

CWHer
Copy link
Contributor

@CWHer CWHer commented Jul 21, 2022

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

@Trinkle23897 Trinkle23897 linked an issue Jul 21, 2022 that may be closed by this pull request
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #705 (86ce32f) into master (99c99bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          72       72           
  Lines        4894     4895    +1     
=======================================
+ Hits         4572     4573    +1     
  Misses        322      322           
Flag Coverage Δ
unittests 93.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/trainer/base.py 96.90% <100.00%> (+0.01%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 merged commit f270e88 into thu-ml:master Jul 22, 2022
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async test_collector seems to cause exception in offpolicy_trainer
3 participants