Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug (#811) #817

Merged
merged 3 commits into from
Mar 4, 2023
Merged

fix bug (#811) #817

merged 3 commits into from
Mar 4, 2023

Conversation

sunkafei
Copy link
Contributor

@sunkafei sunkafei commented Mar 1, 2023

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

Fix the bug#811.

I run the command make commit-checks but the get some errors which are not relevent to my code:

tianshou/policy/modelfree/trpo.py:131:29: B028 No explicit stacklevel keyword argument found. The warn method from the warnings module uses a stacklevel of 1 by default. This will only show a stack trace for the line on which the warn method is called. It is therefore recommended to use a stacklevel of 2 or greater to provide more information to the user.
                            warnings.warn(
                            ^

Just ignore it?

@Trinkle23897
Copy link
Collaborator

I’ll take it, don’t worry

Trinkle23897
Trinkle23897 previously approved these changes Mar 3, 2023
@Trinkle23897 Trinkle23897 changed the title fix bug #811 fix bug (#811) Mar 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #817 (746e2c5) into master (c8be85b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          73       73           
  Lines        5082     5083    +1     
=======================================
+ Hits         4631     4632    +1     
  Misses        451      451           
Flag Coverage Δ
unittests 91.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/data/buffer/her.py 91.86% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Trinkle23897 Trinkle23897 merged commit bc222e8 into thu-ml:master Mar 4, 2023
@Trinkle23897 Trinkle23897 linked an issue Mar 4, 2023 that may be closed by this pull request
8 tasks
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Bug in HERReplayBuffer.
3 participants