Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fancy readme #1392

Merged
merged 1 commit into from Jan 23, 2022
Merged

fancy readme #1392

merged 1 commit into from Jan 23, 2022

Conversation

mvhirsch
Copy link
Contributor

Following #1388, every legendary project needs an awesome README.

Check it out:

@heynemann I noticed you already updated the contributing guides. I just simplified it a bit.

@heynemann
Copy link
Member

Do you mind fixing the weird that's showing in redis in contributing.md?

@mvhirsch
Copy link
Contributor Author

mvhirsch commented Jan 23, 2022

Sorry, but I can't see any issue. What do I need to fix?

EDIT: What do you mean with "showing in redis in contributing.md"?

@heynemann
Copy link
Member

image

This is what I see when I go to contribution.md in your branch...

@mvhirsch
Copy link
Contributor Author

Good catch, fixed! 👍

@heynemann heynemann merged commit c622dea into thumbor:master Jan 23, 2022
@mvhirsch mvhirsch deleted the fancy-readme branch January 23, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants