Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing pyexiv2 #1404

Closed
wants to merge 1 commit into from
Closed

Changing pyexiv2 #1404

wants to merge 1 commit into from

Conversation

heynemann
Copy link
Member

Let's see if that can be done. Would make our docker image much smaller and not depend on boost.

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marcelometal
Copy link
Member

@heynemann
Copy link
Member Author

Yeah gotta change the docs, but first I wanted to make sure tests are passing with the new pyexiv2... Seems to be the same thing.

@kkopachev
Copy link
Member

metadata test was skipped because it could not import ImageMetadata class: https://github.com/thumbor/thumbor/runs/5008775364?check_suite_focus=true#step:7:239.
Not so easy :(

@heynemann
Copy link
Member Author

That's odd, localy it's not skipping and apparently it exists in pyexiv2 https://github.com/LeoHsiao1/pyexiv2/blob/master/docs/Tutorial.md

@kkopachev
Copy link
Member

@heynemann its ImageData vs Imagemetadata ne difference

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove the stale label or add a comment, or this PR will be closed in 10 days. You can always re-open if you feel this is something we should still keep working on. Tag @heynemann for more information.

@github-actions github-actions bot added the Stale label Mar 19, 2022
@github-actions
Copy link

This PR was closed because it has been stale for 10 days with no activity.

@github-actions github-actions bot closed this Mar 29, 2022
@scorphus scorphus deleted the feat/pyexiv2 branch July 30, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants