Normalize images loaded from storage

[thomas-brx]

This PR is a workaround for #1547.

It will run engine.normalization() after the engine has loaded the buffer from storage.

Happy to try to add some tests for this if the workaround feels acceptable.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove the stale label or add a comment, or this PR will be closed in 30 days. You can always re-open if you feel this is something we should still keep working on. Tag @heynemann for more information.

[github-actions]

This PR was closed because it has been stale for 30 days with no activity.

[RaphaelVRossi]

Hey @thomas-brx, first of all, thanks for your contribution!

What do you think about normalize be called after retrieve from storage?

Otherwise, all other calls to method _fetch will be normalized too.

e.g.

[...]
                if (
                    mime == "image/gif"
                    and self.context.config.USE_GIFSICLE_ENGINE
                ):
                    self.context.request.engine = (
                        self.context.modules.gif_engine
                    )
                else:
                    self.context.request.engine = self.context.modules.engine

                fetch_result.normalized = self.context.request.engine.normalize()
                return fetch_result
[...]

[coveralls]

Pull Request Test Coverage Report for Build 5521461086

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.3%) to 86.672%

---

Totals
Change from base Build 5486971773:	0.3%
Covered Lines:	4006
Relevant Lines:	4622

---

💛 - Coveralls

[scorphus]

#1568 didn't see any test, I hope this one tells a different story 😊 Please LMK if I can help with anything.

[devppjr]

Hey @thomas-brx, first of all, thanks for your contribution!

What do you think about normalize be called after retrieve from storage?

Otherwise, all other calls to method _fetch will be normalized too.

e.g.

[...]
                if (
                    mime == "image/gif"
                    and self.context.config.USE_GIFSICLE_ENGINE
                ):
                    self.context.request.engine = (
                        self.context.modules.gif_engine
                    )
                else:
                    self.context.request.engine = self.context.modules.engine

                fetch_result.normalized = self.context.request.engine.normalize()
                return fetch_result
[...]

@RaphaelVRossi thanks, I was testing your idea but I didn't succeed 😢. When we normalize the image we use the image sizes (here), and if we normalized the image at this point we would not have self.size initialized, as the image hasn't yet been loaded with self.context.request.engine.load, like here. IMHO we should keep with @thomas-brx contribution, what do you think?

ps: @scorphus feel free to give your opinion (always) ❤️

[thomas-brx]

@RaphaelVRossi, @devppjr. Thank you so much for taking a look at this, sorry for not being able to respond sooner. Had some issues getting the test suite to run yesterday, but I see a test has been added already 😍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[scorphus]

Awesome to see one more bug being fixed! Thanks all of you for your contributions! ❤️