Replace CurlError with HTTPClientError

[RaphaelVRossi]

The following error:

2023-06-19 19:27:42 thumbor:ERROR ERROR: Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/thumbor/handlers/__init__.py", line 212, in get_image
    result = await self._fetch(self.context.request.image_url)
  File "/usr/local/lib/python3.9/dist-packages/thumbor/handlers/__init__.py", line 884, in _fetch
    loader_result = await self.context.modules.loader.load(
  File "/usr/local/lib/python3.9/dist-packages/thumbor/loaders/http_loader.py", line 202, in load
    response = await client.fetch(req, raise_error=True)
tornado.httpclient.HTTPClientError: HTTP 404: Not Found

Happens because HTTP_LOADER_CURL_ASYNC_HTTP_CLIENT is True and the upstream host returned a 404 status error.

The type of exc_type is tornado.httpclient.HTTPClientError and not the expected tornado.curl_httpclient.CurlError. (CurlError is an extension of HTTPError)

[coveralls]

Pull Request Test Coverage Report for Build 5326467908

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.006%) to 86.389%

---

Totals
Change from base Build 5324675497:	-0.006%
Covered Lines:	3935
Relevant Lines:	4555

---

💛 - Coveralls

[devppjr]

LGTM ✅

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[scorphus]

I'm late to the party but I'm asking anyway — I'm prolly missing something. Are we 100% sure tornado.curl_httpclient.CurlError is not raised in any circumstance?

[RaphaelVRossi]

@scorphus Even this error happening, it will be caught by HTTPClientError block. Since CurlError extends from HTTPError (alias to HTTPClientError)