Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure result storage is passed results in bytes #1578

Merged
merged 1 commit into from Jul 30, 2023
Merged

fix: Ensure result storage is passed results in bytes #1578

merged 1 commit into from Jul 30, 2023

Conversation

scorphus
Copy link
Member

@scorphus scorphus commented Jul 1, 2023

When results are text, such as JSON content for /meta/ endpoints, ensure the results are converted to bytes before passing them to a result storage.

Fix #1577

@scorphus
fix: Ensure result storage is passed results in bytes
a12fb1b 
When results are text, such as JSON content for `/meta/` endpoints,
ensure the results are converted to bytes before passing them to a
result storage.

Fix thumbor#1577
@coveralls
Copy link

coveralls commented Jul 1, 2023 •
edited

Pull Request Test Coverage Report for Build 5705729397

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.687%
Totals Coverage Status
Change from base Build 5648556224: 0.02%
Covered Lines: 4011
Relevant Lines: 4627
💛 - Coveralls

devppjr
devppjr approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@devppjr devppjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@scorphus
Copy link
Member Author

Thanks for the review, @devppjr!

@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scorphus scorphus merged commit a12fb1b into thumbor:master Jul 30, 2023
24 checks passed
@scorphus scorphus deleted the 1577-fix-results-as-bytes branch July 30, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devppjr devppjr devppjr approved these changes

@marcelometal marcelometal Awaiting requested review from marcelometal

@heynemann heynemann Awaiting requested review from heynemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is a file generated every time a meta url is refreshed?
3 participants
@scorphus @coveralls @devppjr