-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engines/pil.read_multiple): Use Pillow to save multipage images as GIF #1643
Conversation
…as GIF The functionality provided by the images2gif module is part of Pillow since 2015 [1]. It also renders `gifsicle` unnecessary in this context. 1. https://pillow.readthedocs.io/en/stable/releasenotes/3.0.0.html
With this change, we're free to remove the version constraints for Pillow: Lines 153 to 154 in 812ed4c
|
Pull Request Test Coverage Report for Build 7762176489
💛 - Coveralls |
a6177fe
to
e197a0c
Compare
c70db60
to
8c1824d
Compare
Please, check #1644 before commenting on lint failure. |
Thanks for your review, @guilhermef. While doing some benchmarks of those changes and seeing a small but welcomed performance improvement of around 5%, I encountered cases where the I already have a draft solution to that which I'll probably propose in a separate PR – as they're apparently unrelated issues. However, merging this as it is forbids us from drafting a new release. So, let's wait until we have both changes ready. #trickyone |
6e1b47f
to
378ab80
Compare
There we go, @guilhermef. I believe we're much better off having no |
|
The functionality provided by the images2gif module is part of Pillow since 2015. It also renders
gifsicle
unnecessary in this context.