New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add curve filter for applying RGB curves. #353
Conversation
Wow! Very good job! I'll try to have a look at it tomorrow. Maybe @cezarsa can help with reviewing this PR! Thanks a lot for the contribution. |
Do you think you can add some tests for this filter? I'd love to merge it already. Sorry for the long delay. If you need a sample of filter tests: |
I thought about it, but find it is difficult to do that. The existed filter tests are all about metadata such as rotation, format or file size. Once it is about actual pixels, there seems no good way to test, such as brightness, contrast or watermark. That is the exact situation of this RGB curve filter. |
Sorry @gockxml, I was about to merge your PR, but github says I can't merge until it's rebased. Can you do it? Thanks! |
No problem. Rebased. |
@@ -267,6 +267,7 @@ | |||
'thumbor.filters.no_upscale', | |||
'thumbor.filters.saturation', | |||
'thumbor.filters.max_age', | |||
'thumbor.filters.curve' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random guy here, I think there should be a trailing comma here so future changes won't cause a diff on this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Thank you!
Sorry but when applying this PR, the build fails due to a test that verifies all the default filters. Can you fix it? The log for the test failure is here: https://api.travis-ci.org/jobs/46025767/log.txt?deansi=true And the travis build is here: https://travis-ci.org/thumbor/thumbor/builds/46025766 Thanks!!! |
@heynemann thank you very much for showing me the complete log. For some weird reason, I couldn't see the whole. I thought the building failure occurred during environment setup. Sorry for my clumsy. |
Add curve filter for applying RGB curves.
Thanks a LOT for your contribution. |
Hey @gockxml Can you please create a wiki page for this plug-in? Thanks! We'll release a version now! |
Added at https://github.com/thumbor/thumbor/wiki/Filters. Thank you! |
Brilliant! |
Add curve filter for applying RGB curves.
Usage
Format of each curve
Examples of use
Original image
Demo 1
Demo 2