Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the gif engine. #432

Merged
merged 1 commit into from
Mar 9, 2015
Merged

Allow configuring the gif engine. #432

merged 1 commit into from
Mar 9, 2015

Conversation

masom
Copy link
Contributor

@masom masom commented Mar 9, 2015

Fixes #431

@masom
Copy link
Contributor Author

masom commented Mar 9, 2015

Hopefully I didn't miss anything?

@guilhermef
Copy link
Member

@masom looks good,
do you mind rebasing this PR ?

@masom
Copy link
Contributor Author

masom commented Mar 9, 2015

@guilhermef rebased

@masom masom closed this Mar 9, 2015
@masom masom reopened this Mar 9, 2015
@guilhermef
Copy link
Member

Thanks @masom I'll just wait for travis, then merge and release a new version.

@masom
Copy link
Contributor Author

masom commented Mar 9, 2015

@guilhermef I'm not sure what happened with the first rebase build. Somehow a test related to Mongo broke.

EDIT: now ✓ OK » 935 honored • 0 broken (16.071940s)

@guilhermef
Copy link
Member

@masom I don't know what happens, sometimes the mongo tests break.

guilhermef added a commit that referenced this pull request Mar 9, 2015
Allow configuring the gif engine.
@guilhermef guilhermef merged commit a315179 into thumbor:master Mar 9, 2015
@masom masom deleted the configure-gif-engine branch March 17, 2015 13:59
christianjgreen pushed a commit to fanhero/thumbor that referenced this pull request Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseHandler should load the gif engine from the Importer / configuration
2 participants