clean up PILLOW_JPEG-options #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
happily looking fwd to any feedback! :) |
|
cc @phoet |
phoet
force-pushed
the
clean_up_jpeg_config
branch
2 times, most recently
from
46e8f18
to
6facbfa
Compare
…oth subsampling and qtables
phoet
force-pushed
the
clean_up_jpeg_config
branch
from
6facbfa
to
b0d29e5
Compare
christianjgreen
pushed a commit
to fanhero/thumbor
that referenced
this pull request
Aug 29, 2017
clean up PILLOW_JPEG-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not happy with the confusing options for PIL-JPEG settings PILLOW_JPEG_SUBSAMPLING (but not PILLOW_JPEG_QTABLES), and PILLOW_COPY_JPEG_SETTINGS (which overrides both QUALITY and PILLOW_JPEG_SUBSAMPLING).
So i tried to clean it up: