Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useRef usage with TextInput #744

Closed
wants to merge 1 commit into from
Closed

Fix useRef usage with TextInput #744

wants to merge 1 commit into from

Conversation

danoc
Copy link
Member

@danoc danoc commented Dec 10, 2020

Relates to #743.

@danoc
Copy link
Member Author

danoc commented Dec 10, 2020

I can't figure out how to get TypeScript working with that test. Any tips?

@mattybow
Copy link
Contributor

@danoc seems like changing L259 to
let ref: React.RefObject<HTMLInputElement> = { current: null };
works

@bgando bgando closed this Aug 5, 2021
@danoc
Copy link
Member Author

danoc commented Aug 5, 2021

Decided to close this because we don't have an immediate need for it. We should revisit if the problem is raised again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavelle lavelle Awaiting requested review from lavelle

@andrejgou andrejgou Awaiting requested review from andrejgou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danoc @mattybow @bgando