Handle deferred comment loading issue #624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
I've been having issues with deferred comments not loading. I found the same issue with the same comments on the web, so it's not strictly a Thunder problem, but I wanted to dig in anyway. It turns out that we occasionally get comments where the none of the children are direct descendants of the parent. For example, the parent path may be
0.10
and the child with ID30
may be0.10.20.30
. I'm not sure why it happens (maybe comment20
got deleted?), but I thought it might be nice to handle this case.Note that since we do actually get the child comments in the response, we could go a step further and insert placeholders for the missing comments so the results are still displayed. But since this seems like a backend issue (which the web client also fails to handle), I think at least showing a nice error message is an improvement.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before (web and app)
chrome_32G3vtemst.mp4
qemu-system-x86_64_uyNhnxDu9T.mp4
After
qemu-system-x86_64_4CNO2okeG7.mp4
Checklist
semanticLabel
s where applicable for accessibility? -- N/A