Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/combine post fab #648

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 17, 2023

Pull Request Description

This PR optionally (and by default) combines the post FAB with the comment navigation buttons. This can be turned off on its own or, of course, turning off comment navigation will also show the regular FAB.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

output.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@machinaeZER0
Copy link
Collaborator

This is beautiful! I would be perfectly happy with this as-is, but throwing an idea out there - instead of containing the FAB icon within the pill shape, what if it was a themed (or just outlined) circle/squircle overlaid on the current pill shape (the latter would match the actual FAB shape so it might be preferable)?

The way I'm envisioning it would make the whole thing a bit wider, and the overlaid FAB would jut out at the top and bottom, so it would definitely obscure more screen real estate - but my thinking is that it would be more obvious that it inherits the properties of the FAB, in that it can be swiped or long-pressed for more options.

Thoughts? Again, if it doesn't seem like a good idea for Thunder (or should be tackled separately from this PR) then no worries!

@micahmo
Copy link
Member Author

micahmo commented Aug 18, 2023

Hey @machinaeZER0, thanks for the feedback as always! I tried to capture your idea from your description. Is this what you pictured?

image

If not, maybe you can mock something up.

Either way, it might be nice to get this in as-is and then improve the styling!

@machinaeZER0
Copy link
Collaborator

Aw, thanks so much for testing that! I was thinking something like that, but maybe I can make a mockup to better encapsulate what's in my brain. I'm away from my computer through the weekend so I'd say stick with what you had for this initial PR and I can keep brainstorming?

@ajsosa ajsosa merged commit 871d7be into thunder-app:develop Aug 24, 2023
1 check passed
@micahmo micahmo deleted the feature/combine-post-fab branch August 24, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants