-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drafts for posts and comments #700
Add drafts for posts and comments #700
Conversation
YYYYEEEEEEEESSSSSSSSS!!!!!!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thanks for taking this on! This is going to be a really nice QoL feature to have :D
I just left a few comments on some parts to consider, but other than those, I think it was done pretty well! One test I would also try out is import/exporting settings and see if the drafts also come with it. I think the appropriate behaviour there is to ensure that we ignore the drafts when we export/import settings
Pull Request Description
This PR introduces drafts for posts and comments. Drafts are saved upon exiting the edit screen (without posting) and on a timer (in case the app is quit/crashes). They are saved per community or post/comment.
At this time, only title/url/text are saved.
I also cleaned up some spots that were still using the modal for comments, which was broken (#716, #721).
I also found that replying to comments with no post context (e.g., inbox replies, user profile comments) is currently broken (to be addressed later).
Issue Being Fixed
Inability to save drafts.
Screenshots / Recordings
qemu-system-x86_64_z2Z9WOrgGJ.mp4
Checklist
semanticLabel
s where applicable for accessibility?