Migrate from old BottomNavigationBar to NavigationBar

[ggichure]

Pull Request Description

This PR migrates from old BottomNavigationBar to NavigationBar

Issue Being Fixed

Issue Number: #764

Screenshots / Recordings

Checklist

• Did you update CHANGELOG.md?
• Did you use localized strings where applicable?
• Did you add semanticLabels where applicable for accessibility?

[hjiangsu]

Hey @ggichure, thanks for the PR!

Unfortunately, with some of the refactor that has been taking place surrounding the feed page, the bottom nav bar code was moved elsewhere. The bottom nav bar code is now in lib/thunder/widgets/bottom_nav_bar. It would be appreciated if you could make the changes to the new file if its not too much work 😅

[ggichure]

Hey @ggichure, thanks for the PR!

Unfortunately, with some of the refactor that has been taking place surrounding the feed page, the bottom nav bar code was moved elsewhere. The bottom nav bar code is now in lib/thunder/widgets/bottom_nav_bar. It would be appreciated if you could make the changes to the new file if its not too much work 😅

Will do and submit a PR by EOD tomorrow.

[hjiangsu]

Thanks, I appreciate it! Sorry again for this 😅

[ggichure]

@hjiangsu I force pushed when rebasing and it closed the PR. Please reopen it, else I can create a new PR.

[hjiangsu]

Reopened! Let me know if its all good on your end

[ggichure]

Reopened! Let me know if its all good on your end

All good. Ready for review.

[hjiangsu]

LGTM!

[hjiangsu]

So I'm just running the latest develop build (with this change) and I'm finding the animations a bit weird when navigating through many pages at once (e.g., navigating from feed page to settings page).

I wonder if we can potentially fix that. I'm assuming this is because we still have the option of animating through pages, which is what is triggering this issue.

RPReplay_Final1696435771.mp4

[ggichure]

So I'm just running the latest develop build (with this change) and I'm finding the animations a bit weird when navigating through many pages at once (e.g., navigating from feed page to settings page).

I wonder if we can potentially fix that. I'm assuming this is because we still have the option of animating through pages, which is what is triggering this issue.
RPReplay_Final1696435771.mp4

I'll have a look.

[micahmo]

@hjiangsu Are you talking about how all of the icons are highlighted at the bottom while it scrolls through the pages? Technically the old nav bar did that as well, but since the highlight wasn't as prominent, it wasn't as noticeable.

This goes back to the discussion we had in Matrix about whether we should really be scrolling through all the pages like that. It is kind of cool, but I think it's also in the minority of apps that do something like that. 😊