Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android back closes community sidebar #907

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Android back closes community sidebar #907

merged 1 commit into from
Nov 23, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Nov 22, 2023

Pull Request Description

This PR allows the Android back gesture to close the community sidebar.

Issue Being Fixed

Issue Number: #889

Screenshots / Recordings

889.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 0956040 into thunder-app:develop Nov 23, 2023
1 check passed
@micahmo micahmo deleted the fix/889-back-close-sidebar branch November 23, 2023 13:07
@micahmo micahmo mentioned this pull request Dec 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micahmo @hjiangsu