Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some back button issues #977

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 13, 2023

Pull Request Description

Like #907, this PR adds support for the Android back button to close the user sidebar.

This also fixes an issue with community pages where the sidebar closing would take priority even if there were another page on top of the navigation stack.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_UH0AvNmIdq.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit f42b1c5 into thunder-app:develop Dec 15, 2023
1 check passed
@micahmo micahmo deleted the fix/back branch December 15, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants