Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating posts with no language #932

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Nov 30, 2023

Pull Request Description

This PR updates the Create Post page to allow setting no language when creating new posts. This matches the web UI and is allowed by the Create Post API. Note that setting no language (null) is different than setting Undetermined (language id 0), although they both display no language name next to the post in the web UI. This also restores the previous behavior of Thunder, which always used to create posts with no language in the past.

Issue Being Fixed

Issue Number: Related to #922 (not the full fix yet)

Screenshots / Recordings

Vw7uMiVouU.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

Note that setting no language (null) is different than setting Undetermined (language id 0), although they both display no language name next to the post in the web UI

That's an interesting observation! Nice catch there - I didn't realize null and Undetermined were two different options.

@hjiangsu hjiangsu merged commit 92eaed4 into thunder-app:develop Nov 30, 2023
1 check passed
@micahmo micahmo deleted the fix/post-no-language branch November 30, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants