Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update Jetpack compose dependency to 2023.06.01 #323

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix: Update Jetpack compose dependency to 2023.06.01 #323

merged 2 commits into from
Aug 1, 2023

Conversation

Prakhar-Agarwal-byte
Copy link
Contributor

No description provided.

thunderbiscuit
thunderbiscuit requested changes Jul 30, 2023
View reviewed changes
Copy link
Owner

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the send screen work on your machine? This is what mine looks like when I test your PR:
screen.

@thunderbiscuit thunderbiscuit mentioned this pull request Jul 30, 2023
Merged
@Prakhar-Agarwal-byte
Copy link
Contributor Author

I missed that, fixed it now. I am now using Constraint Layout, in the same fashion as in RecieveScreen.kt

thunderbiscuit
thunderbiscuit approved these changes Aug 1, 2023
View reviewed changes
Copy link
Owner

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d3dc58f.

@thunderbiscuit thunderbiscuit merged commit d3dc58f into thunderbiscuit:master Aug 1, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Prakhar-Agarwal-byte @thunderbiscuit