Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Use ModalBottomSheetLayout in bottom sheet in send screen #324

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

Prakhar-Agarwal-byte
Copy link
Contributor

@Prakhar-Agarwal-byte Prakhar-Agarwal-byte commented Jul 29, 2023

Fixes #284

Copy link
Owner

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell me more about your changes when you open PRs if you can. For example, I see that ModalBottomSheet was introduced in Material 3 Compose 1.2.0-alpha01, but I also know that your PR #323 uses the BOM to fix the dependencies, including Material 3 to 1.1.1. Do those interact? In theory the ModalBottomSheet should not be available, unless we also fix the gradle dependency but I don't see that here, so I'm a bit unsure. Was it maybe marked as experimental and now is not? Also is that related to the bug I find on the SendScreen in #323? (should I consider one PR dependent on the other for example?).

Here is what the send screen looks
scren 2
like on my machine (i.e. it's missing the background)

@Prakhar-Agarwal-byte
Copy link
Contributor Author

Both PRs #323 and #324 are separate and not interrelated. The background is also missing in my machine, it is yet to be fixed. I will need to give it more time.

@Prakhar-Agarwal-byte
Copy link
Contributor Author

If we can merge #323, I will be able to include the changes in this PR on top of that.

@thunderbiscuit
Copy link
Owner

This PR will also need a quick rebase.

@Prakhar-Agarwal-byte
Copy link
Contributor Author

This PR still has an issue with the top app bar background color. It is white but should be green as with the other screens.
WhatsApp Image 2023-08-08 at 3 42 09 PM

@thunderbiscuit thunderbiscuit merged commit 3b150ba into thunderbiscuit:master Aug 14, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Disable touch opacity when Bottom sheet is expanded.
2 participants