when using activerecord 5 schema_format = :sql still outputs to schema.rb

[kjg]

I just started a new project with standalone-migrations and activerecord 5. I set the schema_format = :sql, but the file created during migrations is still at schema.rb The contents of the file IS SQL however.

Using standalone-migrations with active record 4.2 properly puts the sql in structure.sql, as does running migrations on a fresh Rails 5 install.

It appears that something about the way standalone-migrations interacts with rails 5 causes active record to output the sql to the wrong file

[kjg]

It looks like it is because of this change rails/rails@99e57a8 in which structure dumps now use the path in ENV['SCHEMA'] if set and standalone-migrations sets ENV['SCHEMA'] to db/schema.rb by default.

[twobitlabs]

Can you test with our newest version 5.2.0? If if doesn't work for you we'd love a PR with a fix!

[kjg]

Unfortunately I no longer use standalone-migrations day to day, but I would guess a fix might involve changing this line, and it says it hasn't been touched in 3 years.

Did you make a change that you expect to have fixed this issue? I'd be happy to take a look.

Thanks!

[twobitlabs]

No worries, I just wanted to make sure the issue didn't get left behind. I'll leave this issue open and if someone else comes along that needs that feature they can send a PR with a fix. Standalone migrations is maintained by its active users now and we just review PR's and publish updates when new PR's are merged.

[konstantinn]

Can confirm bug still exists on ~> 5.2.3
schema.rb is generated whatever schema_format is.

Works like this:

ENV['SCHEMA'] = "db/strucutre.sql"
ActiveRecord::Base.schema_format = :sql

[MaxGabriel]

You can workaround this by specifying the schema file name in the .standalone_migrations YAML config file:

db:
    schema: db/schema.sql

You still need to specify the ActiveRecord schema format in the Rakefile:

ActiveRecord::Base.schema_format = :sql

[jmehnle]

The line of code …

      ENV['SCHEMA'] = schema

was originally introduced in #42. I'm not familiar enough with today's Rails/ActiveRecord code to come up with a better solution, but I figure there might be a way to hook into Rails/AR in such a way that allows us to override the path (but not the base name) of the schema/structure dump file. Then we wouldn't have to explicitly set the SCHEMA environment variable.

[jmehnle]

I believe PR #141 addresses this in a better way.

[twobitlabs]

Merged PR #141 and published v5.2.4. Thanks @jmehnle