Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: enable tichi for tidb-tools #205

Merged
merged 3 commits into from
Mar 24, 2021
Merged

config: enable tichi for tidb-tools #205

merged 3 commits into from
Mar 24, 2021

Conversation

Rustin170506
Copy link
Contributor

Part of #173

@ti-chi-bot ti-chi-bot requested a review from Mini256 March 23, 2021 09:51
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 23, 2021
@Rustin170506
Copy link
Contributor Author

Rustin170506 commented Mar 23, 2021 •
edited
Loading

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
lance6716
lance6716 reviewed Mar 23, 2021
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to remove

amyangfei
glorv
GMHDBJD
leoppro
YuJuncens
overvenus
Little-Wallace
liuzix

prow/config/external_plugins_config.yaml Outdated Show resolved Hide resolved
@Rustin170506
Copy link
Contributor Author

prefer to remove

amyangfei
glorv
GMHDBJD
leoppro
YuJuncens
overvenus
Little-Wallace
liuzix

Fixed.

@Rustin170506
Copy link
Contributor Author

@lance6716 PTAL~

@Rustin170506 Rustin170506 added sig/community-infra Indicates that the Issue or PR belongs to the community-infra SIG. sig/migrate Indicates that the Issue or PR belongs to the migrate SIG. labels Mar 23, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2021
@Rustin170506 Rustin170506 changed the title config: enable blunderbuss for tidb-tools config: enable TICHI for tidb-tools Mar 23, 2021
@Rustin170506 Rustin170506 changed the title config: enable TICHI for tidb-tools config: enable tichi for tidb-tools Mar 23, 2021
@Rustin170506
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@Rustin170506
Copy link
Contributor Author

/assign @Mini256

PTAL~ thanks!

@Mini256
Copy link
Member

Mini256 commented Mar 24, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4cd2bb7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2021
@ti-chi-bot ti-chi-bot merged commit 5459535 into ti-community-infra:main Mar 24, 2021
@ti-chi-bot
Copy link
Member

@hi-rustin: Updated the following 3 configmaps:

  • plugins configmap in namespace prow at cluster default using the following files:
    • key plugins.yaml using file prow/config/plugins.yaml
  • config configmap in namespace prow at cluster default using the following files:
    • key config.yaml using file prow/config/config.yaml
  • external-plugins-config configmap in namespace prow at cluster default using the following files:
    • key external_plugins_config.yaml using file prow/config/external_plugins_config.yaml

In response to this:

Part of #173

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rustin170506 Rustin170506 mentioned this pull request Mar 24, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Mini256 Mini256 Mini256 approved these changes

Assignees

@Mini256 Mini256

Labels
sig/community-infra Indicates that the Issue or PR belongs to the community-infra SIG. sig/migrate Indicates that the Issue or PR belongs to the migrate SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rustin170506 @ti-chi-bot @Mini256 @lance6716