-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add full sync for pr #1
Conversation
Mini256
commented
Jan 11, 2021
•
edited
edited
- add full sync for pr on app startup
- dealing with the problem that emoji expression can't be saved
- ignore PR not updated
- add full sync for pr on the app when install on repo
- add test for syncPullRequest method
- fetch sync repo config from installation
- fetch sync repo config from env file (only for test)
- feat: add test for getSyncRepositoryListFromEnv
- add doc
- translate the doc
patch the relation field.ti-sync-bot/src/services/PullService.ts Lines 56 to 61 in f30b1be
This comment was generated by todo based on a
|
Refactor the LaterThan function.Lines 28 to 33 in 7b13b3b
This comment was generated by todo based on a
|
@hi-rustin Cloud you please take a look? |
I will review it tomorrow. |
OK, thanks. |
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 87.95%
=======================================
Files ? 5
Lines ? 83
Branches ? 8
=======================================
Hits ? 73
Misses ? 9
Partials ? 1 Continue to review full report at Codecov.
|
By the way, I think the PR is a bit too big, maybe it's best to keep it to 300-400 lines. |
use the github client authed by installation id.Lines 19 to 24 in 6df27e3
This comment was generated by todo based on a
|
Clean up the unused code temporarily left here.ti-sync-bot/test/index.test.ts Lines 23 to 28 in 6df27e3
This comment was generated by todo based on a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the unexported function, reset LGTM.
Add todo issue for startup event test: #4 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |