This repository has been archived by the owner on Sep 19, 2021. It is now read-only.
Winpty update, PATH and insecure wget fix #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat do not have insecure wget enabled. This is also made silent to keep the prompt clean. Prepending the PATH helped with finding the exe for winpty.
|
PING! |
|
Thanks for your work!
Can you explain how this would help? |
|
I am not 100% on this but with my business machine, I think this is an issue with PATH length. Windows does have limitations. https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx Mine is extremely long so I think that Babun is ignoring after the 260 char limit. |
|
Good point. Thanks for the link and for your work! 🎉 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update winpty Version to 0.4.3.
Update wget to make the request for machines that do not have insecure wget enabled. This is also made silent to keep the prompt clean. It would also explain why people were having issues when doing babun-docker-update and not seeing errors.
Prepending the PATH helped with finding the exe for winpty.